Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport change to use correct map key when deleting endpoints in san… #5310

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

elcasteel
Copy link
Contributor

@elcasteel elcasteel commented Sep 9, 2021

…itizer (#5307)

  • Use the correct map key to delete endpoints in upstream_removing_sanitizer
  • remove unused test
  • Clean up teat and add changelog
  • Merge branch 'master' into missing-kube-service
  • codegen, remove debug printing and log level changes
  • codegen again
  • default endpoint name

Description

Please include a summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves #5022

…itizer (#5307)

* Use the correct map key to delete endpoints in upstream_removing_sanitizer
* remove unused test
* Clean up teat and add changelog
* Merge branch 'master' into missing-kube-service
* codegen, remove debug printing and log level changes
* codegen again
* default endpoint name
@solo-changelog-bot
Copy link

Issues linked to changelog:
#5022

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Sep 9, 2021
@soloio-bulldozer soloio-bulldozer bot merged commit fc72632 into v1.8.x Sep 9, 2021
@soloio-bulldozer soloio-bulldozer bot deleted the backport-sanitizer branch September 9, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants