Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ci #6270

Closed
wants to merge 3 commits into from
Closed

Test ci #6270

wants to merge 3 commits into from

Conversation

kdorosh
Copy link
Contributor

@kdorosh kdorosh commented Apr 7, 2022

Description

test ci

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@kdorosh
Copy link
Contributor Author

kdorosh commented Apr 7, 2022 •
edited
Loading

/skip-changelog (for now)

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1bb1988):

https://gloo-edge--pr6270-route-sanitizer-disa-716d8ldx.web.app

(expires Thu, 14 Apr 2022 21:00:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@kdorosh
Copy link
Contributor Author

kdorosh commented Apr 7, 2022

resolves issue described in #6115 (comment)

@kdorosh kdorosh added work in progress signals bulldozer to keep pr open (don't auto-merge) and removed keep pr updated signals bulldozer to keep pr up to date with base branch labels Apr 7, 2022
@kdorosh
Copy link
Contributor Author

kdorosh commented Apr 10, 2022

closing in favor of #6289

@kdorosh kdorosh closed this Apr 10, 2022
@kdorosh kdorosh deleted the route_sanitizer_disabled branch April 10, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work in progress signals bulldozer to keep pr open (don't auto-merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kdorosh