Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for inheritance #8443

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Docs for inheritance #8443

merged 5 commits into from
Jul 7, 2023

Conversation

artberger
Copy link
Contributor

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

Context

Based on discussion in Slack.

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/main/changelogutils) which references the issue that is resolved.
  • N/A If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • N/A I have performed a self-review of my own code
  • N/A I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • N/A I have added tests that prove my fix is effective or that my feature works

Adding to the concepts page and linking to existing docs on transformation and auth config as examples
@artberger artberger requested a review from a team as a code owner July 6, 2023 13:12
@artberger artberger self-assigned this Jul 6, 2023
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Visit the preview URL for this PR (updated for commit 24ab642):

https://gloo-edge--pr8443-adb-inheritance-kjm6pfvk.web.app

(expires Fri, 14 Jul 2023 15:30:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
@soloio-bulldozer soloio-bulldozer bot merged commit d19f28a into main Jul 7, 2023
12 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the adb-inheritance branch July 7, 2023 17:02
artberger added a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
@artberger artberger mentioned this pull request Jul 7, 2023
5 tasks
artberger added a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
@artberger artberger mentioned this pull request Jul 7, 2023
5 tasks
artberger added a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
@artberger artberger mentioned this pull request Jul 7, 2023
5 tasks
artberger added a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
@artberger artberger mentioned this pull request Jul 7, 2023
5 tasks
soloio-bulldozer bot pushed a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance (#8443)

* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

* changelog

* rm 1.10 content

* version bump

* fix video link, see Slack: https://solo-io-corp.slack.com/archives/CHJV572TG/p1688750427833549

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
soloio-bulldozer bot pushed a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance (#8443)

* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

* changelog

* fix video link, see Slack: https://solo-io-corp.slack.com/archives/CHJV572TG/p1688750427833549

* rm 1.10 content

* version bump

* Update _index.md

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>
soloio-bulldozer bot pushed a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance (#8443)

* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

* changelog

* rm 1.10 content

* version bump

* fix video link, see Slack: https://solo-io-corp.slack.com/archives/CHJV572TG/p1688750427833549

* Update _index.md

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>
soloio-bulldozer bot pushed a commit that referenced this pull request Jul 7, 2023
* Docs for inheritance (#8443)

* Docs for inheritance

Adding to the concepts page and linking to existing docs on transformation and auth config as examples

* changelog

* grammar

* add more detailed header example

* Apply suggestions from code review

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>

* version bump

* fix video link, see Slack: https://solo-io-corp.slack.com/archives/CHJV572TG/p1688750427833549

* rm 1.10 content

* changelog

* Update _index.md

---------

Co-authored-by: Rachael Graham <rachael.graham@solo.io>
Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch Type: Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants