Do not submit enhancements #8470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
|
/skip-ci |
| @@ -22,7 +22,7 @@ DO_NOT_SUBMIT_REGEX="[[:space:]]*//[[:space:]]*DO_NOT_SUBMIT" | |||
| file_count=0 | |||
| for filename in "$@"; do | |||
| # Only check *.go files for now | |||
| if [[ "$filename" == *".go" || "$filename" == *"go.mod" ]]; then | |||
| if [[ "$filename" == *".go" || "$filename" == *"go.mod" || "$filename" == *".proto" ]]; then | |||
There was a problem hiding this comment.
nit: the comment above this line indicates that only go files are checked, but this is no longer true
There was a problem hiding this comment.
There's also a comment at the top of the file
|
/skip-ci |
jbohanon
added
the
work in progress
|
/skip-ci |
|
/skip-ci |
|
/skip-ci |
jenshu
approved these changes
Jul 14, 2023
jbohanon
removed
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor updates to
do-not-submit:Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diff