Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Http Passthrough Auth Doc #8483

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

lamadome
Copy link
Contributor

Description

The doc for Http Passthrough Auth is creating a service with the wrong name for the example auth service.
It uses example-grpc-auth-service instead of example-http-auth-service

Context

Users ran into this bug doing ... \ Users needed this feature to ...

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/main/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@lamadome lamadome requested a review from a team as a code owner July 18, 2023 21:22
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jul 18, 2023
@lamadome lamadome changed the title Update _index.md Update Http Passthrough Auth Doc Jul 18, 2023
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit d859c9f):

https://gloo-edge--pr8483-fix-extauthdoc-jona-9ibyc596.web.app

(expires Tue, 25 Jul 2023 21:56:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@jenshu
Copy link
Contributor

jenshu commented Jul 19, 2023

/skip-changelog

@soloio-bulldozer soloio-bulldozer bot merged commit 2085e8c into main Jul 19, 2023
13 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the fix-extauthDoc-jona branch July 19, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants