-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v2.0.x to main #9117
Merge v2.0.x to main #9117
Conversation
* controller sketch * controllers * helper functions, indexers * maincompile * main * wip * query * gen-cli * query secrets * example-code * git mv edge2/ gateway2 * cleanup * cleanup2 * cleanup3
* rename .github to disable github actions * change cloudbuild.yaml to prevent build-bot running
* change query to have object in the args To confirm that we use the right "from" field, ask for the whole object in the query args, and not just the ns * use obj and infer gk * fix comment comments are bad * singular
* some tests for query * more tests and pr comments * more tests and fixes * mroe test
* ability to deploy to kind so we can run conformance not yet working * helming around, accepting status for gw class * set observed generation on condition * don't create gw for conformance test * minor changes * cleanup * separate cp and dp * cleanup * allow more than one ports * pr comments * controlPlane.enabled * fix makefile
* solo gw stubs * wip: translator * wip: http gwv2 translation * wip: listener tx complete, ready for vhost + validation * merge http filter chain * finish core listener tx; stub vhost tx * remove unused
* initial code to create GW * auto provision by default add ports to deployer * fixes and some PR comments * fix event filtering * write addresses to gw; need to add tests * only reconcile gw when generation changes * support provisioning with different releases * try approach 2 for statues * env test for status setting * pr comments
* fix gw route query to make sure the http routes match * add and pass ci * more ci * make in g2 dir * naming * naming
Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
* solo gw stubs * wip: translator * wip: http gwv2 translation * wip: listener tx complete, ready for vhost + validation * merge http filter chain * wip: initial impl of GW/Listener validation * wip: working sketch of reporter; passing tests * wip: begin testing for conditions * simplify condition type on reporter * add status checks to tests * move listener validation back to listener package * add gateway structure to report impl * use ListenerStatus api type * add support for allowedRoutes * cleaup * add tests for explicit allowedRoutes * cleanup and reorg * correctly track invalid listeners & routes * more cleanup * todo --------- Co-authored-by: Scott Weiss <sdw35@cornell.edu>
* solo gw stubs * wip: translator * wip: http gwv2 translation * wip: listener tx complete, ready for vhost + validation * merge http filter chain * finish core listener tx; stub vhost tx * remove unused * wip: route translator * http route translator, fixes for http listener * clean up todos
* Add simple uds transslator * goimports -w . * format plugin * update kube plugin to export a function that our new discvoery can rely on * add stubs for translator for discovery * add placeholder for legacy impl * formatting * simplify code * add changelog
* query part 2 * add parentref * add conditions * compile fix * compile fix after merge
* create ListenerCondition type * fix unnecessary guard on map access (go-static) * add initial route validation * handle empty/nil hostnames on listeners
* testing and fixes for http translation * get test passing * nit * fix import cycle, gofmt * remove workaround
* add a server to tie everything together * more wiring * enabled devmode * de-pike
* single translation spot * compiles and runs * fix compile issue in tests
* initial route-sorting * tests are passing * update golden * swapped it all to use the httpRoute and idx as fallbacks * also check NS/NAME * oops * move sortable to separate package
* first drop working listener status * handle gateway top-level conditions
* make xds work main bug is there were 2 caches * use envoy-gloo; use unprivileged port * use rc2 for conformance to work * pr comments * tidy
* add no conflicts to healthy listeners * add resolvedrefs to healthy listeners * add per-conditionType logic for missing conditions
* ssl termination * add ssl secret validation * add ssl secret validation
* gateway checking is done * compiles * route status code * with v1 changes * a couple more changes * remove ingress/knative * also apply CRDs with glooctl * pike * install/uninstall work * oops * fix conditions for Gateway Class * change back protocol on svc * removed default gateway from the chart * default to LB * oops * fix env tests with svc status hack due to LB * naming * use index func logic * check for existence of the CRDs * upped template to v1, changed logic to be more permissinve * gatewayName
* init route report * cleanup * switch to per-parentRef reporting on routes * report on route-parent relationship errors * sync route status * cleanup
* don't checkout gw repo for tests * add conformance build tag; simplify kind * fmt
* rename helm-chart * rename folder * change dir name * updated values/versions * add labels so that glooctl version works * make new commands more flexible * file for CRDs, add programmed condition * bad comment * change version to alpha1 instead * comments * rename the gateway class name * use standar * use relative dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really great work, this is exciting to see!
gave a 1st pass and left a few comments/questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a lot of context and not clear exactly what was/is worth reviewing
I ignored files in projects/gateway2, assuming most or all of that was brought from previous PRs
I left a few comments, mainly looking to better understand what's going
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my comments have been addressed
I'll let other reviewers officially approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, excellent work!
Description
Initially, everything for Gloo Gateway v2 was developed separately against the v2.0.x branch. This PR merges all of it back into
main
. Roughly, this merge involved:main
into thev2.0.x
branch, resolving conflicts, and adding back deleted code (mostly in glooctl)make generated-code
workingmain
)Notes for reviewers
The goal of this PR is to merge all work from
v2.0.x
intomain
and ensure CI is passing for both Gloo Edge and Gloo Gateway v2 (with the minimal changes necessary), so that further GGv2 development can be done againstmain
. Not currently looking for thorough review of the PRs that are being pulled directly from v2.0.x (as they had already gotten reviewed when they were initially merged).As long as regression tests / build-bot pass, I'm confident we didn't break anything in GE. GG is likely broken in some places (e.g. glooctl) but will be handled in follow-up PRs (along with cleanup and deduping of GE/GG code).
Checklist: