Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official Ruby Lambda images for S3-mpeg #745

Merged
merged 10 commits into from
Sep 16, 2024
Merged

Conversation

dwilkie
Copy link
Collaborator

@dwilkie dwilkie commented Sep 16, 2024

Todo

  • Rotate services application master key
  • Remove old sentry DSN

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.88%. Comparing base (5eade55) to head (ebe9cf3).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
components/services/lib/encrypted_credentials.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #745      +/-   ##
===========================================
- Coverage    96.88%   96.88%   -0.01%     
===========================================
  Files          169      169              
  Lines         3051     3050       -1     
===========================================
- Hits          2956     2955       -1     
  Misses          95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwilkie dwilkie merged commit 486e33b into develop Sep 16, 2024
26 of 28 checks passed
@dwilkie dwilkie deleted the fix_s3mpeg_lambda branch September 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant