Fix: SonicV2Connector behavior change: get_all will return empty dict if the hash does not exist in Redis #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the hash does not exist in Redis
ref: swsssdk implementation returns None, and the library will be deprecated
libswsscommon implementation returns empty dict
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
SuvarnaMeenakshi
approved these changes
Jul 12, 2021
qiluo-msft
added a commit
that referenced
this pull request
Jul 14, 2021
… if (#226) the hash does not exist in Redis - What I did Fixes sonic-net/sonic-buildimage#8140 ref: swsssdk implementation returns None, and the library will be deprecated libswsscommon implementation returns empty dict - How I did it Relax the condition check to accept both representations - How to verify it Unit test Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
|
@qiluo-msft @SuvarnaMeenakshi Required for 202106 |
judyjoseph
pushed a commit
that referenced
this pull request
Oct 14, 2021
… if (#226) the hash does not exist in Redis - What I did Fixes sonic-net/sonic-buildimage#8140 ref: swsssdk implementation returns None, and the library will be deprecated libswsscommon implementation returns empty dict - How I did it Relax the condition check to accept both representations - How to verify it Unit test Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes sonic-net/sonic-buildimage#8140
ref: swsssdk implementation returns None, and the library will be deprecated
libswsscommon implementation returns empty dict
- How I did it
Relax the condition check to accept both representations
- How to verify it
Unit test
- Description for the changelog