Fix comments

Signed-off-by: Ze Gan <ganze718@gmail.com>
sonic-net · Jul 12, 2023 · e73f7ad · e73f7ad
1 parent 142c060
commit e73f7ad
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/common/rediscommand.cpp b/common/rediscommand.cpp
@@ -128,7 +128,7 @@ int RedisCommand::appendTo(redisContext *ctx) const
     return redisAppendFormattedCommand(ctx, c_str(), length());
 }
 
-std::string RedisCommand::printable_string() const
+std::string RedisCommand::toPrintableString() const
 {
     return binary_to_printable(temp, len);
 }

diff --git a/common/rediscommand.h b/common/rediscommand.h
@@ -30,6 +30,10 @@ class RedisCommand {
     void formatArgv(int argc, const char **argv, const size_t *argvlen);
     void format(const std::vector<std::string> &commands);
 
+    int appendTo(redisContext *ctx) const;
+
+    std::string toPrintableString() const;
+
     /* Format HMSET key multiple field value command */
 #ifndef SWIG
     __attribute__((deprecated))
@@ -66,14 +70,11 @@ class RedisCommand {
     /* Format DEL key command */
     void formatDEL(const std::string& key);
 
-    int appendTo(redisContext *ctx) const;
+    const char *c_str() const __attribute__((deprecated));
 
-    std::string printable_string() const;
+    size_t length() const __attribute__((deprecated));
 
 private:
-    const char *c_str() const;
-
-    size_t length() const;
 
     char *temp;
     int len;

diff --git a/common/redisreply.cpp b/common/redisreply.cpp
@@ -89,9 +89,9 @@ RedisReply::RedisReply(RedisContext *ctx, const RedisCommand& command)
     rc = redisGetReply(ctx->getContext(), (void**)&m_reply);
     if (rc != REDIS_OK)
     {
-        throw RedisError("Failed to redisGetReply with " + command.printable_string(), ctx->getContext());
+        throw RedisError("Failed to redisGetReply with " + command.toPrintableString(), ctx->getContext());
     }
-    guard([&]{checkReply();}, command.printable_string().c_str());
+    guard([&]{checkReply();}, command.toPrintableString().c_str());
 }
 
 RedisReply::RedisReply(RedisContext *ctx, const string& command)
@@ -115,7 +115,7 @@ RedisReply::RedisReply(RedisContext *ctx, const string& command)
 RedisReply::RedisReply(RedisContext *ctx, const RedisCommand& command, int expectedType)
     : RedisReply(ctx, command)
 {
-    guard([&]{checkReplyType(expectedType);}, command.printable_string().c_str());
+    guard([&]{checkReplyType(expectedType);}, command.toPrintableString().c_str());
 }
 
 RedisReply::RedisReply(RedisContext *ctx, const string& command, int expectedType)