FLW-106 Implement icon generation from public key #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ERussel
commented
Aug 14, 2020
ERussel
commented
- add kusama icon generator
- add icon display view
antonkhvorov
approved these changes
Aug 14, 2020
| } | ||
|
|
||
| private func loadIcon() { | ||
| do { | ||
| let icon = try KusamaIconGenerator().generateFromAddress(Constants.address) |
There was a problem hiding this comment.
Why Kusama? I think its standard for Polkadot, for Kusama everyone is just reusing it
There was a problem hiding this comment.
I mean, nothing criminal and probably we can rename it as soon as Kusama will have its own algo for icon. However it might confuse people
There was a problem hiding this comment.
Right. Thanks. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.