Fix unclosed database sessions and tunnels (#688)

sosedoff · Sep 10, 2023 · 22daaad · 22daaad
1 parent 14d8d80
commit 22daaad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/api/api.go b/pkg/api/api.go
@@ -301,6 +301,7 @@ func Disconnect(c *gin.Context) {
 		return
 	}
 
+	DbClient = nil
 	successResponse(c, gin.H{"success": true})
 }
 

diff --git a/pkg/client/client.go b/pkg/client/client.go
@@ -69,7 +69,10 @@ func New() (*Client, error) {
 }
 
 func NewFromUrl(url string, sshInfo *shared.SSHInfo) (*Client, error) {
-	var tunnel *Tunnel
+	var (
+		tunnel *Tunnel
+		err    error
+	)
 
 	if sshInfo != nil {
 		if command.Opts.DisableSSH {
@@ -79,7 +82,7 @@ func NewFromUrl(url string, sshInfo *shared.SSHInfo) (*Client, error) {
 			fmt.Println("Opening SSH tunnel for:", sshInfo)
 		}
 
-		tunnel, err := NewTunnel(sshInfo, url)
+		tunnel, err = NewTunnel(sshInfo, url)
 		if err != nil {
 			tunnel.Close()
 			return nil, err
@@ -524,6 +527,7 @@ func (client *Client) Close() error {
 	}
 	defer func() {
 		client.closed = true
+		client.tunnel = nil
 	}()
 
 	if client.tunnel != nil {