Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new unit angstrom #4

Closed
wants to merge 2 commits into from
Closed

Add a new unit angstrom #4

wants to merge 2 commits into from

Conversation

singularitti
Copy link

While deprecated by the IBWM and the NIST, the unit is still often used in the natural sciences and technology to express sizes of atoms, molecules, microscopic biological structures, and lengths of chemical bonds, the arrangement of atoms in crystals, wavelengths of electromagnetic radiation, and dimensions of integrated circuit parts. --Wiki

@coveralls
Copy link

coveralls commented Sep 22, 2019

Pull Request Test Coverage Report for Build 45

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 44: 0.0%
Covered Lines: 61
Relevant Lines: 61

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 22, 2019

Pull Request Test Coverage Report for Build 45

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 44: 0.0%
Covered Lines: 76
Relevant Lines: 76

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     16    +1     
=====================================
+ Hits           15     16    +1
Impacted Files Coverage Δ
src/UnitfulAtomic.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549ba0f...8d86e11. Read the comment docs.

@sostock
Copy link
Owner

sostock commented Sep 23, 2019

Thanks for the PR!

Since the ångström is based on an SI unit (1 Å = 10⁻¹⁰ m), I feel like it would fit better in Unitful.jl. For example, the barn (1 b = 10⁻²⁸ m²) is also defined in Unitful.jl and not in UnitfulAtomic.jl.

Would you be fine with creating a PR for Unitful.jl instead? If it is rejected for whatever reason, I will gladly merge this.

@singularitti
Copy link
Author

OK, I will have a try.

@sostock
Copy link
Owner

sostock commented Oct 8, 2019

Since PainterQubits/Unitful.jl#271 is now merged, I am closing this.

@sostock sostock closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants