feat: added more information on obj_model setup #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sotrh
requested changes
Jan 14, 2023
| @@ -62,6 +62,8 @@ impl Vertex for ModelVertex { | |||
|
|
|||
| This is basically the same as the original `VertexBufferLayout`, but we added a `VertexAttribute` for the `normal`. Remove the `Vertex` struct in `lib.rs` as we won't need it anymore, and use our new `Vertex` from `model` for the `RenderPipeline`. | |||
|
|
|||
| We will also remove our homemade `vertex_buffer`, `index_buffer` and `num_indicdes`. | |||
There was a problem hiding this comment.
There's a typo here: it should be num_indices not num_indicdes
There was a problem hiding this comment.
I fixed it! Thanks for review :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following the rendering a mesh part, I was kind of lost, so I added a little more info
Edit: I actually had to look at the code to be sure of what I was doing