Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes staging & preview address files #232

Merged
merged 7 commits into from
Sep 19, 2022

Conversation

gigamesh
Copy link
Contributor

@gigamesh gigamesh commented Sep 18, 2022

  • Changes address files: staging.json -> goerli.json & removes preview.json. (closes PRO-392)
  • changes to MIT license (closes PRO-324 )

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2022

🦋 Changeset detected

Latest commit: 97db0f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@soundxyz/sound-protocol Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #232 (97db0f7) into master (c768a43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   85.95%   85.95%           
=======================================
  Files          12       12           
  Lines         413      413           
  Branches       59       59           
=======================================
  Hits          355      355           
  Misses         51       51           
  Partials        7        7           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gigamesh gigamesh mentioned this pull request Sep 19, 2022
@gigamesh gigamesh force-pushed the gigamesh/remove-preview-staging branch from 5cc9fff to 346d76f Compare September 19, 2022 06:20
@linear
Copy link

linear bot commented Sep 19, 2022

@linear
Copy link

linear bot commented Sep 19, 2022

PRO-392 Remove 'preview' from sound-protocol

  • only should have a single goerli deployment
  • for 'preview' deployments, we can run the script & copypasta hardcoded addresses into code repo

@gigamesh gigamesh force-pushed the gigamesh/remove-preview-staging branch 2 times, most recently from cc3ad8c to a1cd21e Compare September 19, 2022 06:34
@gigamesh
Copy link
Contributor Author

@PabloSzx This sort of addresses your comment from your SDK pr. The idea is we'll have a single official deployment on each network.

@gigamesh gigamesh merged commit 572cf0e into master Sep 19, 2022
@gigamesh gigamesh deleted the gigamesh/remove-preview-staging branch September 19, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants