gen:ids on push #240
Merged
gen:ids on push #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5623745 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gigamesh
force-pushed
the
gigamesh/gen-ids-on-build
branch
from
8c48b64
to
0c7518a
Compare
gigamesh
commented
Sep 19, 2022
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| pnpm lint-staged |
There was a problem hiding this comment.
seems excessive to run this for every commit when we also run it in CI
gigamesh
commented
Sep 19, 2022
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env sh | |||
| . "$(dirname -- "$0")/_/husky.sh" | |||
|
|
|||
| pnpm run solhint | |||
| pnpm run solhint && pnpm gen:ids && git add --all && git commit --amend --no-edit | |||
There was a problem hiding this comment.
Ensures src/interfaceIds.ts is always up to date
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 12 12
Lines 409 409
Branches 59 59
=======================================
Hits 351 351
Misses 51 51
Partials 7 7 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vigneshka
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.