-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperMinterV1_1 et al. #296
Merged
vigneshka
merged 23 commits into
vectorized/affiliate-flat-fee-base
from
vectorized/affiliate-flat-fee
Dec 18, 2023
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d0e97dc
Prep files
Vectorized 814e6f2
Reinstall multicaller
Vectorized 56ecca9
forge install: multicaller
Vectorized 289f5f5
Add LibMulticaller.senderOrSigner support
Vectorized 767e950
Tidy
Vectorized 51a192b
freeMintIncentive -> cheapMintIncentive
Vectorized 83f02ac
Add comment on the two types of affiliate fees
Vectorized 00273e4
Remove first collector incentives
Vectorized e993498
Add more comments and use checked math in mintTo
Vectorized 9df9a7a
Add finalAffiliateIncentive to Minted log. Change finalCheapMintFee -…
Vectorized 9d7530b
Add platform airdrop functionality to SuperMinterV1_1 (#298)
Vectorized ab5d9c3
Create modern-shirts-try.md
vigneshka 9dc3992
pin version for typechain
vigneshka 8e48a58
tweak ci
vigneshka 3e86b2b
more ci tweaks
vigneshka babe37c
add back foundry
vigneshka 12c912f
Merge branch 'main' of github.com:soundxyz/sound-protocol into vector…
vigneshka 78f8bd9
bump
vigneshka 4abef49
Merge branch 'main' of github.com:soundxyz/sound-protocol into vector…
vigneshka 44373d5
bump typechain
vigneshka 815ce5b
Merge branch 'main' of github.com:soundxyz/sound-protocol into vector…
vigneshka df00147
Implement fee changes (#299)
Vectorized 30e8987
Update modern-shirts-try.md
vigneshka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@soundxyz/sound-protocol": minor | ||
--- | ||
|
||
SuperMinterV2 et al. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,52 +1,56 @@ | ||
name: Release | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
publish: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout Master | ||
uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- name: Use Node | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: "16.x" | ||
- name: Install Foundry | ||
uses: foundry-rs/foundry-toolchain@v1 | ||
with: | ||
version: nightly | ||
- name: Cache pnpm modules | ||
uses: actions/cache@v2 | ||
env: | ||
cache-name: cache-pnpm-modules | ||
with: | ||
path: ~/.pnpm-store | ||
key: ${{ runner.os }}-${{ hashFiles('./pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}- | ||
- name: install pnpm | ||
run: npm i pnpm@^7.2.1 -g | ||
- name: Install Dependencies | ||
run: pnpm i | ||
|
||
- name: Setup NPM credentials | ||
run: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc | ||
env: | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
|
||
- name: Create Release Pull Request or Publish to npm | ||
id: changesets | ||
uses: dotansimha/changesets-action@v1.3.3 | ||
with: | ||
publish: "pnpm release" | ||
commit: "chore(release): update monorepo packages versions" | ||
title: "Upcoming Release Changes" | ||
createGithubReleases: true | ||
githubReleaseName: ${{ steps.vars.outputs.date }} | ||
env: | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
release: | ||
name: Release | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v4 | ||
with: | ||
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits | ||
fetch-depth: 0 | ||
|
||
- name: Setup PNPM | ||
uses: pnpm/action-setup@v2.2.4 | ||
with: | ||
version: latest | ||
|
||
- name: Setup Node v18 | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 18 | ||
cache: 'pnpm' | ||
|
||
- name: Install Foundry | ||
uses: foundry-rs/foundry-toolchain@v1 | ||
with: | ||
version: nightly | ||
|
||
- name: Install Dependencies | ||
run: pnpm install --no-frozen-lockfile | ||
|
||
- name: Set version variables | ||
id: vars | ||
shell: bash | ||
run: | | ||
echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT | ||
echo "date=$(date +"%B %d, %Y")" >> $GITHUB_OUTPUT | ||
|
||
- name: Create Release Pull Request or Publish to npm | ||
id: changesets | ||
uses: dotansimha/changesets-action@v1.3.3 | ||
with: | ||
publish: 'pnpm release' | ||
commit: 'chore(release): update monorepo packages versions' | ||
title: 'Upcoming Release Changes' | ||
createGithubReleases: true | ||
githubReleaseName: ${{ steps.vars.outputs.date }} | ||
env: | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerning the
MulticallerWithSigner
, how thorough does the review need to be? The library seems covered by the audit, so we're really just considering if we think the function usage here is appropriate. Is this correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The priority will be to check if the usage of
senderOrSigner()
here is safe, assuming that the MulticallerWithSigner is implemented perfectly.I am 96% confident of MulticallerWithSigner.