Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format master plan as Markdown, remove rich HTML formatting #10

Merged
merged 4 commits into from
Oct 19, 2018
Merged

format master plan as Markdown, remove rich HTML formatting #10

merged 4 commits into from
Oct 19, 2018

Conversation

sqs
Copy link
Member

@sqs sqs commented Oct 4, 2018

This makes it easier to update and maintain.

@sqs
Copy link
Member Author

sqs commented Oct 4, 2018

@attfarhan I got a JS error about markdownRemarkData (IIRC) when I tried to access http://localhost:8000/plan after this change. Any pointers on why? The intent of this PR is to make the master plan 100% Markdown-formatted (and be rendered in the same way as https://about.sourcegraph.com/privacy/, very plainly).

(Not high priority)

@attfarhan
Copy link
Contributor

This actually works fine for me. Just need to run prettier to pass CI.

sqs and others added 2 commits October 18, 2018 17:12
@attfarhan attfarhan merged commit afb92fa into master Oct 19, 2018
@attfarhan attfarhan deleted the plan branch October 19, 2018 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sqs @attfarhan