Add page for individual podcast episodes #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks very nice |
aileenrose
reviewed
Jun 3, 2020
website/src/pages/podcast.tsx
Outdated
| } | ||
|
|
||
| export function getHTMLParts(html: string): HTMLParts { | ||
| const doc = document.createElement('html') |
There was a problem hiding this comment.
const doc = document.createElement('html')
I tried to review locally and received an error for 'document'. Should this use:
public componentDidMount() ?
There was a problem hiding this comment.
I fixed this issue, so it should work locally now. Still need to fix the outstanding build errors.
|
Excited to see this! A bit of an aside: the Sourcegraph logo could probably use some whitespace around it, since right now it looks a bit strange against dark backgrounds going all the way to the edge:
(our github org logo has a similar issue on dark backgrounds, ie the GitHub mobile app) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a page for individual podcast episodes: