Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two broken links #1576

Merged
merged 18 commits into from
Sep 15, 2020
Merged

Conversation

dan-pixels360
Copy link
Contributor

No description provided.

dan-pixels360 and others added 18 commits August 24, 2020 10:44
Added a trailing slash to permalinks that get generated in gatsby-node.js and changed the canonical-urls plugin option "noTrailingSlash" to false so the canonical links can match the permalinks containing a trailing slash. The reason for the errors on the sitemap are because the permalinks that are getting generated right now in gatsby-node.js are being generated without a trailing slash and is causing a redirect on the browser. For example if you open this link https://about.sourcegraph.com/blog/introducing-code-search-in-sourcegraph and refresh that page a few times you will notice the url starts with a trailing slash then gets removed which is causing a redirect as you can see here https://www.screencast.com/t/0gpAkd5fSNYR These changes should fix the issue. Thanks and let me know if that works!
Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…avigation-and-code-intelligence.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…new-gitlab-native-integration.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…th-sourcegraph.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…cientists-work-better-together.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…ing-with-sourcegraph.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…services-with-sourcegraph.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…th-sourcegraph.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
…ing.md

Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>
@dan-pixels360 dan-pixels360 requested review from a team as code owners September 15, 2020 16:50
@aileenrose aileenrose merged commit d69584b into sourcegraph:main Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants