Add post type for press releases #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying subscribers in CODENOTIFY files for diff 213ce11...239fbb4.
|
lorihey
suggested changes
Sep 22, 2020
There was a problem hiding this comment.
- https://deploy-preview-1617--sourcegraph.netlify.app/news/
This page subhead says News 2020, but since this page includes both news and press releases, and since it includes items from 2019 also, I'd just remove the subhead (News 2020) completely. - https://deploy-preview-1617--sourcegraph.netlify.app/press-release/
Can you add the Offleash PR contact info to the bottom of this page -- the same that's on the bottom of this page: https://deploy-preview-1617--sourcegraph.netlify.app/news/ - https://deploy-preview-1617--sourcegraph.netlify.app/press-release/ -- I find these summaries hard to read, since they're pulling in all the copy at the top of the page -- the title, subtitle, and opening line of the press release. Is there a way to make this cleaner? Maybe eliminate the subhead? Maybe add some sort of punctuation element (if possible) in between the title and the opening line of copy? I understand that this is how the content is being pulled from the individual press releases pages, but it just looks all mushed together this way.
There is a 2019 subhead, but I'll leave as is.
I can add.
I'll need to look at restructuring that layout. |
- added descriptions to individual press releases to improve excerpts - add anchor links to 2019 and 2020 for /news
lorihey
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add post type for press releases.
-- Banner header should be 'Press release` with no link back to /blog. Actually, it should be linked back to /news.
-- Post page should not display post published date, since PR date is within the post body.
For review:
https://deploy-preview-1617--sourcegraph.netlify.app/press-release/
https://deploy-preview-1617--sourcegraph.netlify.app/press-release/sourcegraph-secures-series-b/
https://deploy-preview-1617--sourcegraph.netlify.app/press-release/sourcegraph-announces-new-gitlab-native-integration/
https://deploy-preview-1617--sourcegraph.netlify.app/press-release/our-abcs-childrens-book/
https://deploy-preview-1617--sourcegraph.netlify.app/news/ (links updated now /press-release/[slug] )