Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update onboarding to include Percy #1695

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Update onboarding to include Percy #1695

merged 1 commit into from
Oct 2, 2020

Conversation

ElizabethStirling
Copy link
Contributor

Not sure if we really use Percy too often, but if we do, it should be part of onboarding. Looking for feedback on this.

@sourcegraph-bot
Copy link
Contributor

Notifying subscribers in CODENOTIFY files for diff fbcb37e...3606cdb.

Notify File(s)
@nicksnyder handbook/engineering/onboarding.md

@daxmc99
Copy link
Contributor

daxmc99 commented Oct 1, 2020

Frontend uses this so perhaps mention @sourcegraph/frontend-engineers ?

quinnkeast
quinnkeast approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@quinnkeast quinnkeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as you, I'm not sure how much it's used, but if it's a tool in the stack we should make it part of onboarding so it's there.

@ElizabethStirling ElizabethStirling merged commit 39c6050 into main Oct 2, 2020
@ElizabethStirling ElizabethStirling deleted the Onboarding-Percy branch October 2, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnkeast quinnkeast quinnkeast approved these changes

@felixfbecker felixfbecker felixfbecker approved these changes

@nicksnyder nicksnyder Awaiting requested review from nicksnyder

@daxmc99 daxmc99 Awaiting requested review from daxmc99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ElizabethStirling @sourcegraph-bot @daxmc99 @quinnkeast @felixfbecker