Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better looking code snippets #210

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Better looking code snippets #210

merged 1 commit into from
Aug 6, 2019

Conversation

ryan-blunden
Copy link
Contributor

@ryan-blunden ryan-blunden commented Aug 5, 2019 •
edited
Loading

Adds padding to code blocks and changes to light text on a dark background, while inline code blocks remain the same.

Screen Shot 2019-08-05 at 4 19 54 PM

@ryan-blunden
Better looking code snippets
27f816c 
Adds padding to code blocks and changes to light text on a dark background.
christinaforney
christinaforney approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@christinaforney christinaforney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Is there any way we could get syntax highlighting into our Markdown? It makes a huge difference in readability, but I'm not sure what it would take to add that to our site.

@ryan-blunden ryan-blunden merged commit 01c82ec into master Aug 6, 2019
@ryan-blunden
Copy link
Contributor Author

Seems fine. Is there any way we could get syntax highlighting into our Markdown? It makes a huge difference in readability, but I'm not sure what it would take to add that to our site.

I'll add this as an issue as yeah, it needs improving.

@sqs sqs deleted the code-snippets branch November 11, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaforney christinaforney christinaforney approved these changes

@attfarhan attfarhan Awaiting requested review from attfarhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryan-blunden @christinaforney