Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Code Insights team page #2140
Add Code Insights team page #2140
Changes from 13 commits
47b7654
fc49d56
e46dba9
7ac4e9b
9337ace
336a3a3
8e23d69
c0b21ff
0eafe90
2682943
b134138
2d5f54f
5262156
d48e749
7df0f4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have said "dedicated UI" for clarity, even if the this milestone's UI form won't be as "dedicated" as something like the campaigns UI yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So like a WYSIWYG editor for creating code insights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of, though I don't know what WYSIWYG means when WYS is code and WYG is a visual graph (is Looker/Bigquery what you mean?) because it might still be code-as-UI here. The core of this is "you don't have to go and set it up like a prototype in your settings file" but "there's a UI that we built for this purpose" even if this isn't its final form as we learn about problems or personas who would prefer a different UI.
The simplest first step would be to just pull out the code insights settings code into its own settings-like editor you access somewhere in the UI so you don't get distracted or confused by a busy interface when setting up an insight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have an outcome like "We have at least one customer created code insight that is actively used"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, great thought.