Update values #2490
Merged
Update values #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "be a good human" with "be welcome and inclusive"
mercadon
requested review from
sqs,
nicksnyder,
christinaforney,
dadlerj and
virginiaulrich
|
Notifying subscribers in CODENOTIFY files for diff c817e22...2794e0d.
|
virginiaulrich
approved these changes
Feb 3, 2021
|
Approved, though do wonder if it should be "be welcoming and inclusive ..." Not sure which is easier to read, so that doesn't change my review, but will comment in case anyone else has a stronger sense of which reads better |
dadlerj
approved these changes
Feb 3, 2021
|
Thanks for the thoughtful wording and structure here! |
nicksnyder
approved these changes
Feb 3, 2021
sqs
approved these changes
Feb 3, 2021
|
All credit goes to @virginiaulrich on the thoughtful update and rewording of this value! 🥇 |
jeanduplessis
approved these changes
Feb 3, 2021
christinaforney
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "be a good human" with "be welcoming and inclusive"