Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HubSpot: check that email is unknown before populating firstSourceURL #2765

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

attfarhan
Copy link
Contributor

HubSpot will pre-populate forms with emails when they are known. If the email is known, we already have a HubSpot contact record, so we don't want to populate first source URL, since they visited the site before we implemented this logic. If we were to populate it for these already-existing contacts, we may cause inaccurate source data.

@attfarhan attfarhan requested a review from a team March 15, 2021 09:47
@sourcegraph-bot
Copy link
Contributor

Notifying subscribers in CODENOTIFY files for diff a4ebd5e...9669068.

Notify File(s)
@sourcegraph/marketing website/src/components/HubSpot.tsx

@attfarhan attfarhan merged commit 348ab7a into main Mar 24, 2021
@attfarhan attfarhan deleted the fa/check-email branch March 24, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants