Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add link to Google's blog #308

Merged
merged 2 commits into from
Nov 11, 2019
Merged

add link to Google's blog #308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b70757
add link to Google's blog
nicksnyder Nov 8, 2019
6021387
Update handbook/engineering/code_reviews.md
nicksnyder Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion handbook/engineering/code_reviews.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ Do:

## What makes an effective code review?

[This blog post](https://medium.com/@schrockn/on-code-reviews-b1c7c94d868c) effectively explains some principals which our team values.
Recommended reading:
nicksnyder marked this conversation as resolved.
Show resolved Hide resolved

- [On code reviews](https://medium.com/@schrockn/on-code-reviews-b1c7c94d868c)
- [Code Health: Respectful Reviews == Useful Reviews](https://testing.googleblog.com/2019/11/code-health-respectful-reviews-useful.html)

The code author and code reviewer have a _shared goal_ to bring the PR into a state that meets our quality standards and the needs that motivated the change.

Expand Down