Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release-3.29.md #3263

Merged
merged 27 commits into from
Jun 23, 2021
Merged

Create release-3.29.md #3263

merged 27 commits into from
Jun 23, 2021

Conversation

abschu
Copy link
Contributor

@abschu abschu commented Jun 9, 2021

Shell for 3.29 release post.

@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jun 9, 2021

Notifying subscribers in CODENOTIFY files for diff 452b030...4bcac70.

Notify File(s)
@sourcegraph/marketing blogposts/2021/release-3.29.md

@content-hacker
Copy link
Contributor

@abschu thanks for getting this started!

@Joelkw
Copy link
Contributor

Joelkw commented Jun 11, 2021

@abschu @content-hacker I've added the code insights updates – normally would try to condense in 1 section, but there really is 2 distinct things here – the "1 click create from search" was requested verbatim from multiple customers and appears on a /search page, and the autosave and the autosuggest/autocomplete features were similarly popular requests and appear on an /create-[type]-insight page. Since the features actually exist on two separate pages, I split the 3 features into two sections so each can have an image and be "unified" to its page.

@malomarrec
Copy link
Contributor

@abschu @content-hacker added 2 batch changes updates, pending video assets!

Copy link
Contributor Author

@abschu abschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourcegraph/product-management - I have gone through and made proposed updates/edits to the changelog and release post. Please review - thanks!

blogposts/2021/release-3.29.md Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Show resolved Hide resolved
blogposts/2021/release-3.29.md Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@abschu abschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebeccadee - the release post is ready for you to review!

Copy link
Contributor

@rebeccadee rebeccadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abschu @Joelkw 👋 Some suggestions and comments for you. Some changelog items are still missing a category, is this intentional?

blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
We're making search results more relevant, starting with better prioritization of repos vs. code in your search results. Search results and suggestions are now ranked by descending star count on sourcegraph.com and customer instances (for repos with stars), making it easier to find specific repos. Start searching on sourcegraph.com to experience the new ranking.

Star count import from github.com/sourcegraph/ghdump is done. We now have 418321 repos with star data in the production repo table.
Suggestions and search results are now ranked by descending star count on sourcegraph.com (and customer instances if repos there have stars). Try it out live!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line was maybe meant to be deleted when the reworded paragraph above was inserted? Appears to be repetition

blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
blogposts/2021/release-3.29.md Show resolved Hide resolved
blogposts/2021/release-3.29.md Outdated Show resolved Hide resolved
abschu and others added 10 commits June 22, 2021 09:17
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
@abschu
Copy link
Contributor Author

abschu commented Jun 22, 2021

@rebeccadee - just went through and incorporated your suggestions and updated the category fields.

@Joelkw - the only outstanding item is the image for the Code Insights update.

@Joelkw
Copy link
Contributor

Joelkw commented Jun 22, 2021

@Joelkw - the only outstanding item is the image for the Code Insights update.

@abschu I assume you're referring to the image issue that rebecca tagged me on, or were there specifically code insights image issues? (That's not a code insights image, but I'm happy to help out. Just wanted to be clear that I added the code insights images/assets by Friday, per the process timeline defined in the handbook, and it's not the code insights team that's holding up the blog post 🙂 / we want to always meet our commitments to marketing).

@abschu
Copy link
Contributor Author

abschu commented Jun 22, 2021

@Joelkw - thank you for fixing the issue - and apologies for incorrectly referring to a Code Insights image. I really appreciate you following the process and sticking with the timelines.

@rebeccadee - the post is ready to go live.

@rebeccadee rebeccadee merged commit d4099e9 into main Jun 23, 2021
@rebeccadee rebeccadee deleted the abschu-patch-6 branch June 23, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants