Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring handbook design more in line with our Brand Guidelines #3896

Merged
merged 4 commits into from
Jul 30, 2021

Conversation

felixfbecker
Copy link
Contributor

@felixfbecker felixfbecker commented Jul 27, 2021

This makes our handbook styles follow the Brand Guidelines more closely. Concretely:

  • Use our font (Source Sans/Code)
  • Use our color palette
  • Update all logos
  • Tweak font sizes and line heights (I tried to stick to the guidelines, but had to make some exceptions for some headings because content didn't fit well)

Other changes:

  • Remove dead CSS I noticed (if you see deleted CSS in the diff, it was never used, there is CSS later in the file overriding it)
  • Use SVG favicon
  • Make logo a bit larger
  • Make # when hovering a heading scale to font size of heading
  • There are also some autoformatting/consistency changes (I would really love to run Prettier over the whole repo sometime soon and set some automatic GitHub action up)

This is a bit of a prerequisite for my PR to add the career levels because I want those to look good, but extracted this part into its own PR.

Before:
image

After:
image

@felixfbecker felixfbecker marked this pull request as ready for review July 27, 2021 10:43
@felixfbecker felixfbecker changed the title Bring handbook more in line with styleguide Bring handbook design more in line with our Brand Guidelines Jul 27, 2021
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🌟

@felixfbecker felixfbecker enabled auto-merge (squash) July 30, 2021 13:16
@felixfbecker felixfbecker merged commit 8b013c4 into main Jul 30, 2021
@felixfbecker felixfbecker deleted the handbook-follow-styleguide branch July 30, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants