Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server:latest -> server:CURRENT_VERSION everywhere #4

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Conversation

dadlerj
Copy link
Member

@dadlerj dadlerj commented Oct 3, 2018

Is there a reason why we use :latest in all of the cloud host deployment docs? I think it's a bit irresponsible to recommend using our insiders/RC for "production" deployments (i.e., when users deploy to cloud hosts).

Also, it's just generally inconsistent with other parts of the docs.

cc @KattMingMing

@dadlerj dadlerj requested a review from slimsag October 3, 2018 18:17
@dadlerj dadlerj changed the title server:latest -> server: everywhere server:latest -> server:CURRENT_VERSION everywhere Oct 3, 2018
@dadlerj
Copy link
Member Author

dadlerj commented Oct 3, 2018

Also, non-official releases break update checks (so, if I'm not mistaken, they'll never get a notification to upgrade):

image

Copy link
Member

@slimsag slimsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is real risk of these not getting updated by accident I think. Can you think of ways we can ensure this won't happen? (explicit docs about needing to do repo-wide search for current version number when updating, or a script to do it)?

@dadlerj
Copy link
Member Author

dadlerj commented Oct 3, 2018

Hah — looks like this issue has already been solved! https://github.com/sourcegraph/website/blob/master/src/components/ServerVersionNumber.tsx

I'll update this PR

I found this component, by the way, from the server release process doc @slimsag

@dadlerj
Copy link
Member Author

dadlerj commented Oct 4, 2018

No idea why CI is failing across the board. Seems unrelated to this PR.

This removes all hardcoded sourcegraph/server:latest instances and replaces them with sourcegraph/server:<server-version-number />, updating which is part of our existing release process @slimsag

I also removed sourcegraph.yaml, a file that doesn't seem to have been used since the day it was added in a PR ~9 months ago (which I only discovered because it referenced sourcegraph/server:latest).

Copy link
Contributor

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to fix a typo.

@attfarhan what is the state of CI here? Is there a way to preview this?

@dadlerj
Copy link
Member Author

dadlerj commented Oct 4, 2018

Thanks!

@attfarhan
Copy link
Contributor

@nicksnyder you can go to Netlify to see the build log. The logs aren’t public yet. You will need to merge or rebase off of master to get this to pass, as I added to build script after this PR was opened.

@dadlerj dadlerj merged commit f92073c into master Oct 4, 2018
@dadlerj dadlerj deleted the ver branch October 4, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants