-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server:latest -> server:CURRENT_VERSION everywhere #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there is real risk of these not getting updated by accident I think. Can you think of ways we can ensure this won't happen? (explicit docs about needing to do repo-wide search for current version number when updating, or a script to do it)?
Hah — looks like this issue has already been solved! https://github.com/sourcegraph/website/blob/master/src/components/ServerVersionNumber.tsx I'll update this PR I found this component, by the way, from the server release process doc @slimsag |
No idea why CI is failing across the board. Seems unrelated to this PR. This removes all hardcoded I also removed sourcegraph.yaml, a file that doesn't seem to have been used since the day it was added in a PR ~9 months ago (which I only discovered because it referenced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to fix a typo.
@attfarhan what is the state of CI here? Is there a way to preview this?
Thanks! |
@nicksnyder you can go to Netlify to see the build log. The logs aren’t public yet. You will need to merge or rebase off of master to get this to pass, as I added to build script after this PR was opened. |
Reminders are not in beta anymore so sign up section is returning error 404 see [https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/] (https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/) and [https://github.com/features/reminders/signup] (https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/)
Reminders are not in beta anymore so sign up section is returning error 404 see [https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/] (https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/) and [https://github.com/features/reminders/signup] (https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/)
Reminders are not in beta anymore so sign up section is returning error 404 see [https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/] (https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/) and [https://github.com/features/reminders/signup] (https://github.blog/changelog/2019-11-14-scheduled-reminders-beta/)
Is there a reason why we use
:latest
in all of the cloud host deployment docs? I think it's a bit irresponsible to recommend using our insiders/RC for "production" deployments (i.e., when users deploy to cloud hosts).Also, it's just generally inconsistent with other parts of the docs.
cc @KattMingMing