Adding reimbursable expenses and budgets #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadlerj
requested changes
Dec 5, 2019
tsenart
reviewed
Dec 5, 2019
tsenart
reviewed
Dec 5, 2019
tsenart
reviewed
Dec 5, 2019
Co-Authored-By: Nick Snyder <nick@sourcegraph.com>
There was a problem hiding this comment.
I had some questions for @dadlerj, he told me to just do a PR review instead :)
| @@ -1,3 +1,63 @@ | |||
| # Spending company money | |||
| Please see below for a list of reimbursable expenses (all in USD). | |||
|
|
|||
| ## One-time expenses | |||
There was a problem hiding this comment.
Regarding the "one time" part, do these budgets ever reset after a some time? I wonder about the case where a teammate is moving a long distance (continents) where it may not make sense economically to move some of these items vs re-buying. Or an item is due for replacement, as all things age.
eseliger
reviewed
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.