Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release anxiety blog post (part 1) #4959

Merged
merged 24 commits into from
Nov 4, 2021
Merged

Release anxiety blog post (part 1) #4959

merged 24 commits into from
Nov 4, 2021

Conversation

nickmyyz
Copy link
Contributor

No description provided.

@nickmyyz nickmyyz self-assigned this Oct 25, 2021
@nickmyyz nickmyyz marked this pull request as draft October 25, 2021 18:02
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Oct 25, 2021

Notifying subscribers in CODENOTIFY files for diff da140a3...bcbad55.

Notify File(s)
@sourcegraph/marketing blogposts/release-anxiety.md

Comment on lines 209 to 211
<p align="center">
<blockquote class="twitter-tweet"><p lang="en" dir="ltr">It’s come to my attention that many people think continuous delivery/deployment is about taking whatever crap you have in version control &amp; shipping it into prod as fast as possible so you can test in prod<br><br>NO<br><br>CD is about making it SAFE to ship your code into prod quickly by:</p>&mdash; Jez Humble (@jezhumble) <a href="https://twitter.com/jezhumble/status/1448318922713821186?ref_src=twsrc%5Etfw">October 13, 2021</a></blockquote> <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebeccadee + @csbailey5t do either of you know how to center an embedded tweet? I copied the embed code from Twitter and tried to align it but it's not showing up in the preview.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmyyz I had to figure this out a while back too – you need to add tw-align-center to the code. You can see some tweets I managed to center in this post: https://raw.githubusercontent.com/sourcegraph/about/main/blogposts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md

Let me know if you need a hand!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmyyz I would go with Rebecca's suggestion since it's adding a single class. I did it a bit differently, but to the same effect here.

Copy link
Contributor

@rebeccadee rebeccadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmyyz Thank you for taking on my half-baked idea and turning it into a thoughtful deep dive into release anxiety and CD! Let me know what you think of my suggestion to make this a two-parter. There's a chance we could still publish part 1 tomorrow as I see we have a v1 image in already 🤞

(Just a heads up: I haven't done a proper line edit of the whole thing yet as I wanted to get your feedback on splitting it first)

blogposts/release-anxiety.md Outdated Show resolved Hide resolved
blogposts/release-anxiety.md Outdated Show resolved Hide resolved
blogposts/release-anxiety.md Outdated Show resolved Hide resolved
blogposts/release-anxiety.md Outdated Show resolved Hide resolved
blogposts/release-anxiety.md Outdated Show resolved Hide resolved
nickmyyz and others added 5 commits November 1, 2021 10:35
@nickmyyz
Copy link
Contributor Author

nickmyyz commented Nov 1, 2021

@rebeccadee this, now part one, is ready for your re-review. Some of the checks are failing though, so I haven't seen the preview. Any idea what's wrong?

@rebeccadee rebeccadee self-requested a review November 2, 2021 13:35
@rebeccadee
Copy link
Contributor

@nickmyyz

Some of the checks are failing though, so I haven't seen the preview. Any idea what's wrong?

This is fixed now, I will review and let you know when you can take over again, thanks!

@rebeccadee rebeccadee changed the title Create release anxiety post Release anxiety blog post (part 1) Nov 3, 2021
Copy link
Contributor

@content-hacker content-hacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some stylistic suggestions. Are we planning to publish part 2 very soon after this? With the content split, the post leaves me wanting some sort of resolution or "ok, what do I do about it?" so I think we should not wait long to publish the rest.

nickmyyz and others added 4 commits November 3, 2021 11:46
Co-authored-by: Erica Lindberg <73327004+content-hacker@users.noreply.github.com>
@nickmyyz nickmyyz marked this pull request as ready for review November 4, 2021 14:10
@nickmyyz nickmyyz enabled auto-merge (squash) November 4, 2021 14:13
@nickmyyz nickmyyz merged commit 4236ac6 into main Nov 4, 2021
@nickmyyz nickmyyz deleted the release-anxiety-article branch November 4, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants