docs: emphasize that port 80 needs to be reachable for lets encrypt #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attfarhan
approved these changes
Oct 3, 2018
slimsag
reviewed
Oct 3, 2018
docs/server/tutorials/tlsssl.md
Outdated
| - Your `appURL` site configuration option begins with `https://...`. | ||
| - The host is reachable on port `80` and port `443`. | ||
|
|
||
| - 🚨 [Lets Encrypt requires that port `80` be reachable in order prove that you own your domain](https://letsencrypt.readthedocs.io/en/latest/challenges.html#http-01-challenge). If port `80` is unreachable, HTTPS will fail with errors such as the following: |
There was a problem hiding this comment.
I think it would be better to put this warning + the errors at the end of the section here. Otherwise, it is hard to read the bullet points here about if the following conditions are met: without losing your train of thought and/or not realizing more bullets come after.
slimsag
reviewed
Oct 3, 2018
|
@slimsag PTAL, updated |
cassiemelani
added a commit
that referenced
this pull request
Sep 7, 2021
add clarity to professional development stipend and educational travel clause #5
Merged
cassiemelani
added a commit
that referenced
this pull request
Sep 13, 2021
* Update travel.md add clarity to professional development stipend and educational travel clause #5 * squash! Prettier Co-authored-by: cassiemelani <cassiemelani@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: sourcegraph/sourcegraph#252