Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update career post #5180

Merged
merged 7 commits into from
Mar 30, 2022
Merged

Update career post #5180

merged 7 commits into from
Mar 30, 2022

Conversation

nickmyyz
Copy link
Contributor

@nickmyyz nickmyyz commented Mar 7, 2022

@rebeccadee Not super urgent but I noticed they've updated the engineering career ladder so I wanted to make sure we reflected that. See https://sourcegraph.slack.com/archives/C0EPTDE9L/p1645212239210889

For posts like these, do you think it would be useful to include a changelog at the top documenting changes as they're made?

@rebeccadee Not super urgent but I noticed they've updated the engineering career ladder so I wanted to make sure we reflected that. See https://sourcegraph.slack.com/archives/C0EPTDE9L/p1645212239210889
@nickmyyz nickmyyz requested a review from rebeccadee March 7, 2022 22:19
@nickmyyz nickmyyz self-assigned this Mar 7, 2022
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Mar 7, 2022

Notifying subscribers in CODENOTIFY files for diff 996b8e7...cc3815a.

Notify File(s)
@sourcegraph/marketing blogposts/2021/career-framework.md
website/.vscode/settings.json
website/.vscode/tasks.json
website/tsconfig.json

rebeccadee
rebeccadee previously approved these changes Mar 8, 2022
Copy link
Contributor

@rebeccadee rebeccadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmyyz You are closer to this topic than me so you might understand, what happened to IC7?

To answer your question about a changelog of sorts, I've seen articles have a note at the bottom about the date when they were updated and why. I think that could work without distracting people at the outset of the post, what do you think?

blogposts/2021/career-framework.md Outdated Show resolved Hide resolved
@nickmyyz
Copy link
Contributor Author

nickmyyz commented Mar 8, 2022

I'm not sure actually! I'll ask and maybe ask for a review here too to make sure we're accurate.

@nickmyyz
Copy link
Contributor Author

nickmyyz commented Mar 9, 2022

@lguychard @yinquanteo tagging you both in for a non-urgent review! I saw we deprecated IC7 and added profiles for IC5 so I wanted to make sure our post reflects the framework's current state.

@yinquanteo
Copy link
Contributor

yinquanteo commented Mar 11, 2022

@nickmyyz Thanks for thinking about this and for reaching out. My 2 cents – the career framework is something organic that will continually evolve. The existing dimensions (proficiency, execution, teamwork), definition of IC5, creating of IC6, and other components are all things that can change or be added to.

Rather than coming back to edit the blog post each time it changes**, my recommendation is to add in your blog post somewhere that "this is what our career framework looks like as of xxx date but it's something that's evolving as we learn and grow as a company etc. here's a link to the source of truth (i.e. what's in our handbook)."

Does that work?

** Someone is definitely going to forget doing that. The reason you're proposing this change to the post in the first place is presumably because you noticed my announcement regarding the launch of IC5. I'd imagine there will be many changes that don't warrant an announcement. And that unless you build some process around being notified of all the changes, you're not going to have visibility into that.

cc @chrispine, @nicksnyder, @felixfbecker who are also co-authors on the original post in case you had any thoughts on the topic

nicksnyder
nicksnyder previously approved these changes Mar 11, 2022
Copy link
Contributor

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to do a minor edit here to remove IC 7 (I proposed updated edits because I think the original diff here is actually not correct) and I also agree with Yink. I don't think we should necessarily expect to keep this up-to-date over time.

blogposts/2021/career-framework.md Outdated Show resolved Hide resolved
[IC5](https://handbook.sourcegraph.com/engineering/career-development/framework#ic5) describes “A different IC role from levels 1-4, with a focus on technical leadership.”

[IC6](https://handbook.sourcegraph.com/engineering/career-development/framework#ic6) and [IC7](https://handbook.sourcegraph.com/engineering/career-development/framework#ic7) are deliberately left without bullet points, having not yet been finalized.
[IC5](https://handbook.sourcegraph.com/engineering/career-development/framework#ic5) and [IC6](https://handbook.sourcegraph.com/engineering/career-development/framework#ic6) are deliberately left without bullet points because the impact an IC5 and IC6 makes will vary between individuals. For IC5, we've put together a [list of profiles](https://handbook.sourcegraph.com/departments/product-engineering/engineering/career-development/ic5/) that evoke common traits amongst IC5 engineers. Here, we encourage engineers to use these profiles in "career growth conversations between ICs and EMs, and in calibration discussions between EMs and directors."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit here should just be to delete IC 7.

Suggested change
[IC5](https://handbook.sourcegraph.com/engineering/career-development/framework#ic5) and [IC6](https://handbook.sourcegraph.com/engineering/career-development/framework#ic6) are deliberately left without bullet points because the impact an IC5 and IC6 makes will vary between individuals. For IC5, we've put together a [list of profiles](https://handbook.sourcegraph.com/departments/product-engineering/engineering/career-development/ic5/) that evoke common traits amongst IC5 engineers. Here, we encourage engineers to use these profiles in "career growth conversations between ICs and EMs, and in calibration discussions between EMs and directors."
[IC5](https://handbook.sourcegraph.com/engineering/career-development/framework#ic5) describes “A different IC role from levels 1-4, with a focus on technical leadership.”
[IC6](https://handbook.sourcegraph.com/engineering/career-development/framework#ic6) is deliberately left without bullet points, having not yet been finalized.

@nickmyyz
Copy link
Contributor Author

@yinquanteo @nicksnyder thanks both! I'll accept the edits and add a note at the top explaining that this article is a snapshot in time and link to the handbook source of truth.

Co-authored-by: Rebecca Dodd <82806852+rebeccadee@users.noreply.github.com>
Co-authored-by: Nick Snyder <nick@sourcegraph.com>
@nickmyyz nickmyyz dismissed stale reviews from nicksnyder and rebeccadee via 41100ee March 14, 2022 14:56
@nickmyyz
Copy link
Contributor Author

@rebeccadee I think this is ready to merge given Nick's feedback. Would you mind giving this a stamp when you can?

blogposts/2021/career-framework.md Outdated Show resolved Hide resolved
blogposts/2021/career-framework.md Outdated Show resolved Hide resolved
@nickmyyz nickmyyz merged commit 0b69edd into main Mar 30, 2022
@nickmyyz nickmyyz deleted the career-post-update branch March 30, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants