-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HubSpot syntax on Vulnerabilities gated page #5507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notifying subscribers in CODENOTIFY files for diff b02a7b6...cf3dbec.
|
Pushed an update to the PDF so that the title will display in the browser tab: 8de1fa0! |
bretthayes
suggested changes
Jun 23, 2022
Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com>
bretthayes
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going the extra mile on this one @zlonko!
bretthayes
added a commit
that referenced
this pull request
Jul 22, 2022
* capture user landing source * master form IDs * convert hook to component * gated layout api changes * consolidate forms * prettier * rename component * deprecate HubSpotEmbed for the new HubSpotForm * migrate talk to a developer page from info.sg * consolidate contact pages into one layout * prettier * cleanup and fix broken links on old pages * merge conflict fixes for new API changes * prettier * populate hidden form fields * simplify import/export * convert ChiliPiper hook to prop * cleanup and documentation * merge conflict follow up fixes * deprecate form legal * Update HubSpot syntax on Vulnerabilities gated page (#5507) * add guide and pdf * update guide copy * add Title to PDF * Update src/pages/guides/how-google-fixes-vulnerabilities.tsx Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com> Co-authored-by: Brett Hayes <bretthayes@users.noreply.github.com> * docs * lowercase * async load scripts * deprecate request-demo and redirect to demo * master form for hackathons and sub-processors * master form name change * optimizations and UTM param fix for #5488 * prettier * deprecate talk to a dev * inline message with generic response * updates for meta and form submission messages - meta added to terms sub pages - custom form submission messages to HubSpotForms - GatedResourceLayout updated to allow for a custom form submission message - HubSpotForm form submission messages fall back with a generic message if none is provided - window.open removed from guides pages for more preferred UX best practice - added tailwind whitespace utility class placeholder and restricted title prop to be a string only, for our GatedResourceLayout * title * title style for SEO improvement * prettier/merge conflict fix * bug fix to prevent dupe ChiliPiper scheduler * rm code change contact page and redirect to /demo * pathname for form submission source and bug fix * prettier * use landing source as fallback if no sgSourceUrl * use href for more accuracy and insight * prettier Co-authored-by: Tim Zielonko <60713139+zlonko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the existing "How Companies Fix Vulnerabilities" gated page to conform with the new HubSpot syntax. It is intended to merge into the HubSpot Master Forms update.
Original PR: #5506
Changelog
form
prop onhow-google-fixes-vulnerabilities.tsx
Test