Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move duplicated HubSpot code into HubSpot component #641

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Move duplicated HubSpot code into HubSpot component #641

merged 1 commit into from
Mar 5, 2020

Conversation

ryan-blunden
Copy link
Contributor

No description provided.

@ryan-blunden ryan-blunden self-assigned this Mar 5, 2020
@ryan-blunden ryan-blunden force-pushed the rb-refactor-hhubspot-form-create branch from 68c6aa8 to d0f72f8 Compare March 5, 2020 05:18
vanesa
vanesa suggested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@vanesa vanesa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need sales.tsx at all? I'm not seeing it being used anywhere after adding the new component.

@ryan-blunden
Copy link
Contributor Author

I'm not seeing it being used anywhere after adding the new component.

That's where the Talk to a product specialist links go to.

aileenrose
aileenrose approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@aileenrose aileenrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ryan-blunden ryan-blunden merged commit 5ce5208 into master Mar 5, 2020
@ryan-blunden ryan-blunden deleted the rb-refactor-hhubspot-form-create branch March 5, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aileenrose aileenrose aileenrose approved these changes

@vanesa vanesa vanesa approved these changes

@sqs sqs Awaiting requested review from sqs

@attfarhan attfarhan Awaiting requested review from attfarhan

Assignees

@ryan-blunden ryan-blunden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryan-blunden @aileenrose @vanesa