Added Universal Code Search blog post for GitLab #662
Merged
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-blunden
requested review from
christinaforney,
aileenrose,
vanesa,
adamfrankl2015 and
adaaaam
ryan-blunden
force-pushed
the
rb-universal-code-search-gitlab
branch
from
914808f
to
ce2b440
Compare
adamfrankl2015
approved these changes
Mar 13, 2020
christinaforney
approved these changes
Mar 13, 2020
|
|
||
| This screencast (with accompanying audio) shows how to [connect and configure](https://docs.sourcegraph.com/admin/external_service/gitlab) Sourcegraph Universal Code Search for public and private repositories on GitLab.com and GitLab CC/EE instances | ||
|
|
||
| In addition to connection configuration, it discusses important factors for determining which repositories Sourcegraph will index, such as excluding archived repositories, as well as repositories based on naming patterns such `deploy-`. |
There was a problem hiding this comment.
Suggested change
| In addition to connection configuration, it discusses important factors for determining which repositories Sourcegraph will index, such as excluding archived repositories, as well as repositories based on naming patterns such `deploy-`. | |
| In addition to configuring the Sourcegraph-GitLab connection, the screencast discusses important factors for setting up your Sourcegraph instance, such as determining which repositories Sourcegraph will index, excluding archived repositories, or including repositories based on naming patterns (e.g.,`deploy-`). |
There was a problem hiding this comment.
I incorporated most of these changes, thanks!
|
|
||
| See the [Sourcegraph GitLab documentation](https://docs.sourcegraph.com/admin/external_service/gitlab) for full configuration options, including [enabling repository permissions](https://docs.sourcegraph.com/admin/external_service/gitlab#repository-permissions). | ||
|
|
||
| The script used in the screencast to search for repositories to ignore is available as a [GitLab snippet](https://gitlab.com/snippets/1952534). |
There was a problem hiding this comment.
This reads awkwardly but I don't have an improvement. There are some typos in the comment of your script, and I think there's a stray 'f' on line 14.
There was a problem hiding this comment.
Thanks, fixed the typos in the script and I'll re-work this sentence.
vanesa
reviewed
Mar 13, 2020
|
|
||
| See the [Sourcegraph GitLab documentation](https://docs.sourcegraph.com/admin/external_service/gitlab) for full configuration options, including [enabling repository permissions](https://docs.sourcegraph.com/admin/external_service/gitlab#repository-permissions). | ||
|
|
||
| The script used in the screencast to search for repositories to ignore is available as a [GitLab snippet](https://gitlab.com/snippets/1952534). |
There was a problem hiding this comment.
Suggested change
| The script used in the screencast to search for repositories to ignore is available as a [GitLab snippet](https://gitlab.com/snippets/1952534). | |
| You can use this [Python script](https://gitlab.com/snippets/1952534) used in the screencast to search for repositories you want to exclude. |
There was a problem hiding this comment.
I took your idea and incorporated it into a new version of this sentence. Thanks!
vanesa
approved these changes
Mar 13, 2020
Co-Authored-By: Christina Forney <christina@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blog post with embedded video for configuring GitLab as a code host.