Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGM-6880 - Bitbucket solutions page #6890

Merged
merged 10 commits into from
May 3, 2024
Merged

SGM-6880 - Bitbucket solutions page #6890

merged 10 commits into from
May 3, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Apr 22, 2024

Description:

Refs:
SG Issue
Gitstart ticket

DEMO:
https://deploy-preview-6890--sourcegraph.netlify.app/solutions/bitbucket

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for sourcegraph ready!

Name Link
🔨 Latest commit f91210d
🔍 Latest deploy log https://app.netlify.com/sites/sourcegraph/deploys/6634e616c3ddc50008e3f7e4
😎 Deploy Preview https://deploy-preview-6890--sourcegraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gitstart-sourcegraph gitstart-sourcegraph self-assigned this Apr 22, 2024
@gitstart-sourcegraph gitstart-sourcegraph linked an issue Apr 22, 2024 that may be closed by this pull request
@gitstart-sourcegraph gitstart-sourcegraph marked this pull request as ready for review April 22, 2024 17:50
@iskyOS iskyOS requested a review from kelvinyap April 25, 2024 17:43
@kelvinyap
Copy link
Contributor

Hi @gitstart-sourcegraph this looks good! One request for the Contact us button at the top:

image

The URL is currently /contact/request-info?form_submission_source=solutions-gitlab

Can we change this to /contact/request-info?form_submission_source=solutions-bitbucket please?

@gitstart-sourcegraph
Copy link
Contributor

The URL is currently /contact/request-info?form_submission_source=solutions-gitlab

Can we change this to /contact/request-info?form_submission_source=solutions-bitbucket please?

Noted @kelvinyap Thank you

@kelvinyap
Copy link
Contributor

Thank you! I'll endeavour to be clearer with needs and requirements in future too - I appreciate your patience while I find my feet around here :)

@kelvinyap
Copy link
Contributor

@gitstart-sourcegraph Hi team, I'm seeing a little quirk when clicking on the contact us button - it doesn't seem to be passing the correct parameter over. Here's a Loom showing what I'm seeing:

https://www.loom.com/share/f595249e3c7342a4aafc1559f7135775?sid=b165b03c-4ebf-4dfc-ae45-15e84417865c

@gitstart-sourcegraph
Copy link
Contributor

@gitstart-sourcegraph Hi team, I'm seeing a little quirk when clicking on the contact us button - it doesn't seem to be passing the correct parameter over. Here's a Loom showing what I'm seeing:

Thanks @kelvinyap, this is noted. We will push a fix for that today

@kelvinyap
Copy link
Contributor

@gitstart-sourcegraph sorry team, one final change (I promise it'll be the last one!). Can we please move this section:

image

Further up the page, to here:

Screenshot 2024-05-02 at 2 59 04 pm

@gitstart-sourcegraph
Copy link
Contributor

@gitstart-sourcegraph sorry team, one final change (I promise it'll be the last one!). Can we please move this section:

This is noted @kelvinyap. We should push an update soon

@kelvinyap kelvinyap merged commit 9c31617 into main May 3, 2024
6 checks passed
@kelvinyap kelvinyap deleted the SGM-6880 branch May 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitbucket solutions page
2 participants