Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGM-6881 - Code Search vs GitHub code search page #6892

Merged
merged 3 commits into from
Apr 29, 2024
Merged

SGM-6881 - Code Search vs GitHub code search page #6892

merged 3 commits into from
Apr 29, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Apr 25, 2024 •
edited by gitstart-sourcegraph
Loading

@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024 •
edited
Loading

✅ Deploy Preview for sourcegraph ready!

Name Link
🔨 Latest commit 6c8e0ac
🔍 Latest deploy log https://app.netlify.com/sites/sourcegraph/deploys/662c1ced9b36240008fa6342
😎 Deploy Preview https://deploy-preview-6892--sourcegraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gitstart-sourcegraph gitstart-sourcegraph self-assigned this Apr 25, 2024
@gitstart-sourcegraph gitstart-sourcegraph marked this pull request as ready for review April 25, 2024 14:33
@gitstart-sourcegraph gitstart-sourcegraph linked an issue Apr 25, 2024 that may be closed by this pull request
Code Search vs GitHub code search page #6881
Closed
@kelvinyap
Copy link
Contributor

kelvinyap commented Apr 25, 2024 •
edited
Loading

Thanks @gitstart-sourcegraph ! A few requests below. I was going to record a Loom but it seems down at the moment, sorry :/

  1. Can we please bold each of the headings at the top of each table? E.g. Search, Navigation, Large scale code changes etc.
image
  1. Can we please replace the 'Get Cody, the AI coding assistant' section and replace it with the one found in https://sourcegraph.com/code-search?
image
  1. Can we please remove the 'Compare other code AI assistants' section at the bottom? It's related to a different product (Cody) so it feels weird using it here. Apologies for not catching this and the item below earlier!

@gitstart-sourcegraph
Copy link
Contributor

This is noted @kelvinyap
Thank you for the review.

@kelvinyap kelvinyap merged commit ac642d1 into main Apr 29, 2024
6 checks passed
@kelvinyap kelvinyap deleted the SGM-6881 branch April 29, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskyOS iskyOS Awaiting requested review from iskyOS

@traceyljohnson traceyljohnson Awaiting requested review from traceyljohnson

@kelvinyap kelvinyap Awaiting requested review from kelvinyap

Assignees

@gitstart-sourcegraph gitstart-sourcegraph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Search vs GitHub code search page
2 participants
@kelvinyap @gitstart-sourcegraph