Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blogpost: The home offices of Sourcegraph #695

Merged
merged 30 commits into from
Mar 27, 2020

Conversation

mrnugget
Copy link
Contributor

@mrnugget mrnugget commented Mar 24, 2020

This PR was caused by this discussion in Slack.

So, if you want to participate and show off your home office setup:

  1. Take a photo for your home office, resize to 1600px wide to reduce file-size.
  2. Add your photo to https://console.cloud.google.com/storage/browser/sourcegraph-assets/about.sourcegraph.com/blog/?forceOnBucketsSortingFiltering=false&authuser=1&folder=true&organizationId=true&project=sourcegraph-dev
  3. Edit the blog post markdown file in this PR and add your name, title and link to your photo.

Preview at https://deploy-preview-695--sourcegraph.netlify.com/blog/home-offices-of-sourcegraph

Deadline: Friday, March 27th 2020, 18:00 CET / 10:00 PST

@mrnugget mrnugget changed the title Add blogpost: The home office setups of Sourcegraph Add blogpost: The home offices of Sourcegraph Mar 24, 2020
@efritz
Copy link
Contributor

efritz commented Mar 24, 2020

This PR needs more JPEG.

Copy link
Contributor

@christinaforney christinaforney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, wondering what format is best for this so it lives for longer :)

blogposts/home-offices-of-sourcegraph.md Outdated Show resolved Hide resolved
blogposts/home-offices-of-sourcegraph.md Show resolved Hide resolved
@slimsag
Copy link
Member

slimsag commented Mar 25, 2020

Please do not commit binary files to this repository. It is trivial to create a bucket on Google Cloud and upload them and link them there.

@slimsag
Copy link
Member

slimsag commented Mar 25, 2020

You might also consider running these images through mozjpeg (lossy) or jpegtran (lossless) to compress them.

@nicksnyder
Copy link
Contributor

Might be nice to link to everyone's name to their entry on our team page in the handbook.

@aileenrose aileenrose self-requested a review March 25, 2020 21:07
Co-Authored-By: Christina Forney <christina@sourcegraph.com>
@mrnugget
Copy link
Contributor Author

Please do not commit binary files to this repository. It is trivial to create a bucket on Google Cloud and upload them and link them there.

I didn't know what the preferred way was but saw that other blog posts also have their images directly in this repository, so I thought I'd go with that.

From my personal experience I don't like binary files in repos either, but on the other hand I've seen blogposts work longer when the assets are right next to them and there's no danger of someone saying "what's that folder? looks like we don't need it, let's remove it" when going through cloud storage.

If we go with Google Cloud, though, I can move the assets to the same bucket that you used, though.

@nicksnyder
Copy link
Contributor

@ryan-blunden Can you create some documentation on "How to create a blog post" that includes how images should be handled? If we don't want images checked in to this repo it would be nice to clean existing ones up so they don't set a bad example.

@mrnugget mrnugget merged commit d903ad8 into master Mar 27, 2020
@mrnugget mrnugget deleted the blogpost/home-office-setups branch March 27, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.