SGM-6970 - Add IDs to all buttons in the navbar #6989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
✅ Deploy Preview for sourcegraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@gitstart-sourcegraph It looks like the on-hover highlighting for the menu buttons isn't working in the preview. Tested in both Chrome + Arc on the desktop view:
|
iskyOS
requested changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by GitStart to address the requirements from this ticket: SGM-6970.
This ticket was imported from: SGM-6970
Description:
Adds id of "topnav" to all buttons and dropdowns in the website navbar which would aid in better analytics.
Demo:
https://www.loom.com/share/44207f3aaa974eeb92f91edcfb762ad1?sid=961dbb8c-4508-4bc0-8865-03e07ea98af6
Test cases:
Inspection of navbar buttons displays an id of "topnav" for both desktop and mobile views
Test plan:
Check demo video