SGM-6984 - Update Tailwind custom spacing #6992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
✅ Deploy Preview for sourcegraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
traceyljohnson
previously approved these changes
Jun 10, 2024
chris-sev
previously approved these changes
Jun 10, 2024
|
@gitstart-sourcegraph This is good to merge. Can you resolve the conflicts? |
gitstart-app
bot
dismissed stale reviews from chris-sev and traceyljohnson
via
8c467ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by GitStart to address the requirements from this ticket: SGM-6984.
This ticket was imported from: SGM-6984
Description:
Updated the spacing scale to the new scale specified on the figma link: https://www.figma.com/design/o1QRtdQI0ozKq0n7ATrKlx/Marketing-DLS?node-id=7649-36393&m=dev
Note: 4xl spacing was subsitituted for name #16
DEMO:
https://www.loom.com/share/61a970b7e5304dd798d4c42f3cd693d9?sid=11e88915-9b6b-43e2-be9d-f12804ddd8e2
Test Cases:
Upated spacing name and values match those provided in the figma design
Old spacing scale name values are accounted for in the new design
Old spacing names are updated to the new naming across the site