Update featured blog posts for home page #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-blunden
requested review from
nicksnyder,
mrnugget,
aileenrose,
vanesa,
adamfrankl2015 and
adaaaam
ryan-blunden
commented
Apr 1, 2020
| @@ -1,5 +1,6 @@ | |||
| --- | |||
| title: "Our journey to all-remote" | |||
| title: Our journey to all-remote | |||
| description: On February 20, 2020, we officially moved out of our amazing San Francisco office and became an all-remote company. Few people have worked at an all-remote company before, and I frequently get questions—especially from candidates—about what led to this decision. | |||
There was a problem hiding this comment.
Added a custom description as the auto-generated one includes the alt text from the hero image.
ryan-blunden
commented
Apr 1, 2020
| Read more | ||
| </a> | ||
| </div> | ||
| {posts.map(({ title, description, thumbnail, url, active }, i) => ( |
There was a problem hiding this comment.
Removed the filtering of inactive posts. Was a well-intentioned idea but needlessly complicates things.
ryan-blunden
commented
Apr 1, 2020
| @@ -53,7 +53,6 @@ export default class BlogPosts extends React.Component<any, any> { | |||
| By {post.node.frontmatter.author} on {post.node.frontmatter.publishDate} | |||
| </p> | |||
| <p className="blog-posts__post__excerpt"> | |||
| ( | |||
There was a problem hiding this comment.
This was never meant to be there.
mrnugget
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.