Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Terms of Service & Privacy Policy #90

Merged
merged 8 commits into from
Apr 22, 2019
Merged

new Terms of Service & Privacy Policy #90

merged 8 commits into from
Apr 22, 2019

Conversation

dadlerj
Copy link
Member

@dadlerj dadlerj commented Mar 12, 2019

No description provided.

@francisschmaltz
Copy link
Contributor

Took a quick look and I love the added color splashes!

@dadlerj dadlerj marked this pull request as ready for review March 22, 2019 23:17
@dadlerj dadlerj requested a review from sqs March 22, 2019 23:17
@dadlerj
Copy link
Member Author

dadlerj commented Mar 22, 2019

This is updated! @sqs this is probably dead last in your stack of priorities right now, and no rush on it, but it's worth you taking a peek at the terms-private.md and terms-dotcom.md files, to see how the wording strikes you before this is merged.

Still to do:

  • Add dates
  • Once merged, email all users about updated terms

@dadlerj dadlerj changed the title WIP: new Terms of Service & Privacy Policy new Terms of Service & Privacy Policy Apr 5, 2019
@dadlerj
Copy link
Member Author

dadlerj commented Apr 5, 2019

Totally forgot about this PR, @sqs let me know if you'd like to review!

Copy link
Contributor

@francisschmaltz francisschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just two things:

  1. If there is a card section, it should be full width on mobile
  2. long links/text should break.

Screen Shot 2019-04-05 at 3 24 58 PM

@dadlerj
Copy link
Member Author

dadlerj commented Apr 22, 2019

@francisschmaltz let me know if this works for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants