Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handbook: Update steps for adding ping data #939

Merged
merged 2 commits into from
May 15, 2020
Merged

Conversation

ryanslade
Copy link
Contributor

A couple of small additions having just gone through this process.

A couple of small additions having just gone through this process.
Copy link
Contributor

@ebrodymoore ebrodymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @ryanslade 👍

Copy link
Contributor

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add @ebrodymoore and @dadlerj as CODEOWNERS for this file specifically?

@ryanslade ryanslade requested a review from sqs as a code owner May 15, 2020 07:36
@ryanslade
Copy link
Contributor Author

Can you add @ebrodymoore and @dadlerj as CODEOWNERS for this file specifically?

Done

@ryanslade ryanslade merged commit fae5821 into master May 15, 2020
@ryanslade ryanslade deleted the clarify-ping-steps branch May 15, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants