Skip to content
This repository has been archived by the owner on Nov 25, 2021. It is now read-only.

feat: delay hiding the overlay #418

Merged
merged 1 commit into from
Nov 11, 2021
Merged

feat: delay hiding the overlay #418

merged 1 commit into from
Nov 11, 2021

Conversation

chrismwendt
Copy link
Contributor

Resolves #48

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #418 (9b6507f) into master (338ed2b) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   85.91%   86.03%   +0.12%     
==========================================
  Files          14       14              
  Lines         653      659       +6     
  Branches      175      177       +2     
==========================================
+ Hits          561      567       +6     
  Misses         92       92              
Impacted Files Coverage Δ
src/hoverifier.ts 86.00% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338ed2b...9b6507f. Read the comment docs.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the best way to try this out with a local Sourcegraph instance? I'd love to give it a spin.

delay hiding the overlay

There's been recent discussions about using the term "popover" instead of hover/overlay. Not sure if we want to change anything in this repo yet but just wanted to bring it up since the PR title uses the word "overlay". cc/ @jjinnii

@chrismwendt
Copy link
Contributor Author

To try this locally:

  • Check out this PR, then yarn link
  • yarn run watch
  • cd into sourcegraph/sourcegraph then yarn link "@sourcegraph/codeintellify"
  • sg start enterprise-codeintel
  • Hover over some tokens

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried this locally! LGTM 👍 We may want to increase the delay a bit more but lets collect more feedback first.

@chrismwendt chrismwendt merged commit 03ac028 into master Nov 11, 2021
@chrismwendt chrismwendt deleted the delay-hiding branch November 11, 2021 16:25
@jjinnii
Copy link

jjinnii commented Nov 11, 2021

@olafurpg @chrismwendt Thanks for tagging me! Obviously, this PR is merged now but if there's something in our repo that says overlay or for future PR related to the popover, it would be great if we could label "code intel popover" for clarity!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay hiding the tooltip when mouse is moved away
3 participants