Remove remnants from "LSIF Typed" #191
Conversation
The codebase had a lot of outdated references to "LSIF Typed", which has been renamed to SCIP. This commit replaces these outdated references to avoid confusion for people who are reading the codebase for the first time.
|
cc/ @mrnugget @valerybugakov who both asked about the usage of LSIF in scip-typescript |
| type Descriptor = scip.scip.Descriptor | ||
| const Descriptor = scip.scip.Descriptor | ||
| type Suffix = scip.scip.Descriptor.Suffix | ||
| const Suffix = scip.scip.Descriptor.Suffix |
There was a problem hiding this comment.
nit: Can we somehow avoid this being scip.scip. It's not a big deal, but it looks a little gross lol.
There was a problem hiding this comment.
I agree it's not nice and I'd +1 if we can solve it somehow. It's not a regression from this PR though, it was gross before as well
|
Any idea why the CI is not triggering? |
| import { Packages } from './Packages' | ||
| import { Range } from './Range' | ||
| import * as scip from './scip' | ||
| import { ScipSymbol } from './ScipSymbol' |
There was a problem hiding this comment.
nit: Following JS/TS conventions, I think this should be called SCIPSymbol, similar to HTML and URL in browser APIs.
There was a problem hiding this comment.
I recall seeing in relation to XMLHttpRequest that the convention is that only three-letter acronym should remain uppercase. I really dislike SCIPSymbol, it's easier IMO to read ScipSymbol so I prefer to keep it
|
Nothing seems to have changed in the CI config, so I'm as confused as you are. Some transient GitHub issue? Maybe try pushing a dummy commit? |
|
Empty commit seems to have done the trick |
The codebase had a lot of outdated references to "LSIF Typed", which has been renamed to SCIP. This commit replaces these outdated references to avoid confusion for people who are reading the codebase for the first time.
Test plan
See the CI go green. This should be a pure refactoring, no functional difference.