Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: migrate to Nix Flakes #43668

Merged
merged 1 commit into from
Oct 31, 2022
Merged

nix: migrate to Nix Flakes #43668

merged 1 commit into from
Oct 31, 2022

Conversation

Strum355
Copy link
Contributor

Migrates our Nix devshell to the Cool and New Nix Flakes:tm:. Going forward, nix develop will replace nix-shell to use this

Test plan

N/A, dev-env things

@Strum355 Strum355 added the nix For Nix(OS) related issues/PRs label Oct 31, 2022
@Strum355 Strum355 self-assigned this Oct 31, 2022
@cla-bot cla-bot bot added the cla-signed label Oct 31, 2022
keegancsmith
keegancsmith approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much excite. I thought we would have problems because of our impure shell hook (ie starting redis and postgres).

@Strum355 Strum355 enabled auto-merge (squash) October 31, 2022 15:05
@Strum355 Strum355 merged commit 7853ce8 into main Oct 31, 2022
@Strum355 Strum355 deleted the nsc/nix-flakes branch October 31, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

@stefanhengl stefanhengl Awaiting requested review from stefanhengl

Assignees

@Strum355 Strum355

Labels
cla-signed nix For Nix(OS) related issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strum355 @keegancsmith