log rbac-related backend events #49181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
|
Oops I beat you to the site admin thing: https://github.com/sourcegraph/sourcegraph/pull/49180 😂 |
Haha! Thank you Kelli. I'll rebase once that's merged into main then. |
BolajiOlajide
force-pushed
the
bo/log-rbac-events
branch
from
8e5eacd
to
5e26d2c
Compare
BolajiOlajide
force-pushed
the
bo/log-rbac-events
branch
from
5e26d2c
to
1fa88d8
Compare
courier-new
approved these changes
Mar 13, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 13, 2023
This PR adds a logger for events, so rbac-related events can be viewed in the `event_logs` table. I also removed the constraint where a site admin can't assign a role to themselves. ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> * Manual testing * Update unit tests. (cherry picked from commit 0ac73dd)
BolajiOlajide
added a commit
that referenced
this pull request
Mar 13, 2023
This PR adds a logger for events, so rbac-related events can be viewed in the `event_logs` table. I also removed the constraint where a site admin can't assign a role to themselves. ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> * Manual testing * Update unit tests. <br> Backport 0ac73dd from #49181 Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a logger for events, so rbac-related events can be viewed in the
event_logstable.I also removed the constraint where a site admin can't assign a role to themselves.
Test plan