[Backport 5.0] SCIM: Fix some random issues #49573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- **Giving 404 response for invalid IDs**: Okta validator sends stuff like `010101001010101011001010101011` to check nonexistent users. We returned `400` to these, which made the tests fail. We now return `404`. - **Simplified docs**: The `scim.identityProvider` setting was mentioned as required, and its description wasn't that specific and led me to believe that this setting was more than just "standard/Azure AD". I've marked it as optional, and cleared up its description. - **Renamed two constants** to match Go standards. (My IDE gave a warning on these.) - **Deleted unused arguments** to get rid of code warnings. - I also **fixed some typos** in comments. - Tested with Azure AD validator and Okta's SPEC validator. (cherry picked from commit e1f8f7a)
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 331716e and 530863b or learn more. Open explanation
|
vdavid
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains these changes:
010101001010101011001010101011to check nonexistent users. We returned400to these, which made the tests fail. We now return404.scim.identityProvidersetting was mentioned as required, and its description wasn't that specific and led me to believe that this setting was more than just "standard/Azure AD". I've marked it as optional, and cleared up its description.Test plan
Backport e1f8f7a from SCIM: Fix some random issues #49393