[Backport 5.0] Simplify telemetry structure; eliminate difference between critical and non-critical telemetry #49610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…nd non-critical telemetry (#48866) Proof of concept PR here. I'm failing in Buildkite and am struggling resolving some of them (I can't even seem to get prettier to run anymore, it's been too long). I would love to work with @andersonlauren and @ryphil to (1) make specific reductions to our telemetry as part of this or soon after, and (2) get eng support to fully clean up and remove the old config option. ## Test plan * Run a local instance, set disableNonCriticalTelemetry to true * See if any errors appear * Confirm telemetry sent is identical regardless of the value of the configuration option above <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> --------- Co-authored-by: Aditya Kalia <32119652+akalia25@users.noreply.github.com> Co-authored-by: Joe Chen <joe@sourcegraph.com> (cherry picked from commit 0337361)
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 44f3406 and 530863b or learn more. Open explanation
|
ryphil
approved these changes
Mar 17, 2023
dadlerj
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept PR here. I'm failing in Buildkite and am struggling resolving some of them (I can't even seem to get prettier to run anymore, it's been too long). I would love to work with @andersonlauren and @ryphil to (1) make specific reductions to our telemetry as part of this or soon after, and (2) get eng support to fully clean up and remove the old config option.
Test plan
<!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Backport 0337361 from #48866